| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 31/49] xfs: remove __KERNEL__ check from xfs_dir2_leaf.c |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Fri, 26 Jul 2013 09:16:45 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1374215120-7271-32-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-32-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 07/19/13 01:25, Dave Chinner wrote: From: Dave Chinner<dchinner@xxxxxxxxxx> It's actually an ifndef section, which means it is only included in userspace. however, it's deep within the libxfs code, so it's unlikely that the condition checked in userspace can actually occur (search an empty leaf) through the libxfs interfaces. i.e. if it can happen in usrspace, it can happen in the kernel, so remove it from userspace too.... Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx> --- Looks good for the kernel. Reviewed-by: Mark Tinguely <tinuguely@xxxxxxx> |
| Previous by Date: | Re: [PATCH 32/49] xfs: xfs_filestreams.h doesn't need __KERNEL__, Mark Tinguely |
|---|---|
| Next by Date: | Re: [PATCH 30/49] xfs: remove __KERNEL__ from debug code, Mark Tinguely |
| Previous by Thread: | [PATCH 31/49] xfs: remove __KERNEL__ check from xfs_dir2_leaf.c, Dave Chinner |
| Next by Thread: | [PATCH 32/49] xfs: xfs_filestreams.h doesn't need __KERNEL__, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |