| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 44/49] xfs: Reduce allocations during CIL insertion |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Tue, 23 Jul 2013 16:15:27 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1374215120-7271-45-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-45-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 07/19/13 01:25, Dave Chinner wrote: From: Dave Chinner<dchinner@xxxxxxxxxx> Now that we have the size of the object before the formatting pass is called, we can allocation the log vector and it's buffer in a single allocation rather than two separate allocations. Store the size of the allocated buffer in the log vector so that we potentially avoid allocation for future modifications of the object. While touching this code, remove the IOP_FORMAT definition. Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx> Looks good. Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> |
| Previous by Date: | Re: [PATCH 00/49] xfsprogs: patches for crc-dev branch, Michael L. Semon |
|---|---|
| Next by Date: | Re: [PATCH 46/49] xfs: Combine CIL insert and prepare passes, Mark Tinguely |
| Previous by Thread: | [PATCH 44/49] xfs: Reduce allocations during CIL insertion, Dave Chinner |
| Next by Thread: | Re: [PATCH 44/49] xfs: Reduce allocations during CIL insertion, Michael L. Semon |
| Indexes: | [Date] [Thread] [Top] [All Lists] |