Re: [PATCH 10/60] xfs: Inode create transaction reservations

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 10/60] xfs: Inode create transaction reservations
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Sun, 23 Jun 2013 12:29:49 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1371617468-32559-11-git-send-email-david@xxxxxxxxxxxxx>
References:	<1371617468-32559-1-git-send-email-david@xxxxxxxxxxxxx> <1371617468-32559-11-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 06/18/13 23:50, Dave Chinner wrote:

Define the log and space transaction sizes. Factor the current
create log reservation macro into the two logical halves and reuse
one half for the new icreate transactions. The icreate transaction
is transparent to all the high level create code - the
pre-calculated reservations will correctly set the reservations
dependent on whether the filesystem supports the icreate
transaction.

Signed-off-by: Dave Chinner<david@xxxxxxxxxxxxx>
---


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 04/60] xfs: don't use speculative prealloc for small files, (continued) Re: [PATCH 04/60] xfs: don't use speculative prealloc for small files, Mark Tinguely [PATCH 07/60] xfs: Introduce ordered log vector support, Dave Chinner Re: [PATCH 07/60] xfs: Introduce ordered log vector support, Mark Tinguely [PATCH 08/60] xfs: Introduce an ordered buffer item, Dave Chinner Re: [PATCH 08/60] xfs: Introduce an ordered buffer item, Mark Tinguely [PATCH 09/60] xfs: Inode create log items, Dave Chinner Re: [PATCH 09/60] xfs: Inode create log items, Mark Tinguely [PATCH 06/60] xfs: xfs_ifree doesn't need to modify the inode buffer, Dave Chinner Re: [PATCH 06/60] xfs: xfs_ifree doesn't need to modify the inode buffer, Mark Tinguely [PATCH 10/60] xfs: Inode create transaction reservations, Dave Chinner Re: [PATCH 10/60] xfs: Inode create transaction reservations, Mark Tinguely <= [PATCH 11/60] xfs: Inode create item recovery, Dave Chinner Re: [PATCH 11/60] xfs: Inode create item recovery, Mark Tinguely [PATCH 12/60] xfs: Use inode create transaction, Dave Chinner Re: [PATCH 12/60] xfs: Use inode create transaction, Mark Tinguely [PATCH 17/60] xfs: split out attribute fork truncation code into separate file, Dave Chinner [PATCH 13/60] xfs: remove local fork format handling from xfs_bmapi_write(), Dave Chinner [PATCH 14/60] xfs: move getdents code into it's own file, Dave Chinner [PATCH 20/60] xfs: move xfs_getbmap to xfs_extent_ops.c, Dave Chinner [PATCH 16/60] xfs: split out attribute listing code into separate file, Dave Chinner [PATCH 15/60] xfs: reshuffle dir2 definitions around for userspace, Dave Chinner

Previous by Date:	Re: [PATCH 08/60] xfs: Introduce an ordered buffer item, Mark Tinguely
Next by Date:	Re: group for tests that are dangerous for verifiers?, Dave Chinner
Previous by Thread:	[PATCH 10/60] xfs: Inode create transaction reservations, Dave Chinner
Next by Thread:	[PATCH 11/60] xfs: Inode create item recovery, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]