Re: [PATCH] xfs_repair: remove unconditional ASSERT(0)

To:	Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject:	Re: [PATCH] xfs_repair: remove unconditional ASSERT(0)
From:	Rich Johnston <rjohnston@xxxxxxx>
Date:	Tue, 12 Mar 2013 10:44:54 -0500
Cc:	xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<513F40AD.10303@xxxxxxxxxxx>
References:	<513F40AD.10303@xxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1


On 03/12/2013 09:50 AM, Eric Sandeen wrote:

I don't know what I was thinking in 7e8e3cc, but I added an
ASSERT(0) in the main path.  Obviously this isn't right.

Just remove it.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---

Really sorry, no idea what is up w/ my brain lately.
Trying to do too many things at once, too quickly.

I can relate.  Thanks for the quick fix.

Looks good:

Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>

This has been committed.

Thanks
--Rich

commit b326e067f1005d584bd8ad21bb9f3e2700230e29
Author: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date:   Tue Mar 12 14:50:21 2013 +0000

    xfsprogs xfs_repair: remove unconditional ASSERT(0)

    I don't know what I was thinking in 7e8e3cc, but I added an
    ASSERT(0) in the main path.  Obviously this isn't right.

    Just remove it.

    Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
    Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>
    Signed-off-by: Rich Johnston <rjohnston@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfs_repair: remove unconditional ASSERT(0), Eric Sandeen Re: [PATCH] xfs_repair: remove unconditional ASSERT(0), Rich Johnston <=

Previous by Date:	[PATCH] xfs_repair: remove unconditional ASSERT(0), Eric Sandeen
Next by Date:	Re: [PATCH] xfsdump: properly set Parent's PID, Rich Johnston
Previous by Thread:	[PATCH] xfs_repair: remove unconditional ASSERT(0), Eric Sandeen
Next by Thread:	Re: [PATCH] xfsdump: properly set Parent's PID, Rich Johnston
Indexes:	[Date] [Thread] [Top] [All Lists]