Re: [PATCH] xfstests: handle new mkfs.btrfs -f option cleanly

To:	Eric Sandeen <sandeen@xxxxxxxxxx>
Subject:	Re: [PATCH] xfstests: handle new mkfs.btrfs -f option cleanly
From:	Rich Johnston <rjohnston@xxxxxxx>
Date:	Tue, 5 Mar 2013 14:23:39 -0600
Cc:	xfs-oss <xfs@xxxxxxxxxxx>, linux-btrfs <linux-btrfs@xxxxxxxxxxxxxxx>, Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<512D1E3E.9050907@xxxxxxxxxx>
References:	<512D1E3E.9050907@xxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

Looks good.

Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>

This patch has been committed.

Thanks
--Rich

commit 24fef70ef3fa0be047264b7a40b0bcf86533ec22
Author: Eric Sandeen <sandeen@xxxxxxxxxx>
Date:   Tue Feb 26 20:42:38 2013 +0000

    xfstests: handle new mkfs.btrfs -f option cleanly

    I added an "-f" option to mkfs.btrfs to force overwrite
    of an existing filesystem.  Now on an xfstests run, new
    mkfs.btrfs requires it, and old mkfs.btrfs cannot accept
    it.

    So, add a helper which works out whether -f is needed,
    and add it to the MKFS_BTRFS_PROG env. var as necessary,
    so that it is an always-included option during the tests.

    Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
    Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>
    Signed-off-by: Rich Johnston <rjohnston@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH] xfstests: handle new mkfs.btrfs -f option cleanly, Rich Johnston <=

Previous by Date:	Re: [PATCH] xfstests: use native definition of O_DIRECT flag, Rich Johnston
Next by Date:	Re: strange behavior of a larger xfs directory, Hans-Peter Jansen
Previous by Thread:	Re: [PATCH] xfstests: use native definition of O_DIRECT flag, Rich Johnston
Next by Thread:	Re: [PATCH 07/16] xfs: add CRC checks for quota blocks, Ben Myers
Indexes:	[Date] [Thread] [Top] [All Lists]