Re: [PATCH 2/8] libxfs: initialize xfs_alloc

xfs

Re: [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures

To:	Eric Sandeen <sandeen@xxxxxxxxxx>
Subject:	Re: [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Mon, 28 Jan 2013 08:21:08 -0600
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1359240032-11576-3-git-send-email-sandeen@xxxxxxxxxx>
References:	<1359240032-11576-1-git-send-email-sandeen@xxxxxxxxxx> <1359240032-11576-3-git-send-email-sandeen@xxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 01/26/13 16:40, Eric Sandeen wrote:

This is a merge-to-userspace of kernel commit a0041684
xfs: zero allocation_args on the kernel stack

When calling xfs_alloc_vextent args.userdata was uninitialized,
and if we had args.type==XFS_ALLOCTYPE_START_BNO, this uninit
structure member got tested, leading to some random allocator
behavior.

Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---


I remember seeing this in Dave's:

        [UBER-PATCH, RFC] xfsprogs: sync libxfs to 3.8-rc2 kernel code

http://patchwork.xfs.org/patch/4683/

--Mark.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/8] xfsprogs: misc small fixes, Eric Sandeen [PATCH 3/8] libxfs: fix setup_cursor array allocation, Eric Sandeen [PATCH 6/8] xfs_fsr: check strdup results properly in initallfs(), Eric Sandeen [PATCH 5/8] xfs_fsr: guard against path string overflows, Eric Sandeen [PATCH 8/8] xfs_fsr: remove extraneous close() in fsrallfs(), Eric Sandeen [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures, Eric Sandeen Re: [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures, Dave Chinner Re: [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures, Eric Sandeen Re: [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures, Ben Myers Re: [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures, Mark Tinguely <= [PATCH 1/8] libhandle: Guard against string overflow in path_to_fspath(), Eric Sandeen [PATCH 4/8] xfs_repair: Fix free of uninit ptr in xfs_acl_valid() error path, Eric Sandeen [PATCH 7/8] xfs_fsr: fix attribute no_change_count logic, Eric Sandeen

Previous by Date:	Re: [PATCH] xfs: remove unneeded ASSERT from xfs_itruncate_extents, Mark Tinguely
Next by Date:	Re: [PATCH v2 2/2] xfsprogs: sync transaction log spaces changes to the user space, Mark Tinguely
Previous by Thread:	Re: [PATCH 2/8] libxfs: initialize xfs_alloc_arg structures, Ben Myers
Next by Thread:	[PATCH 1/8] libhandle: Guard against string overflow in path_to_fspath(), Eric Sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]