Re: [PATCH 3/5] xfs: always hold the iolock when calling xfs_change

xfs

Re: [PATCH 3/5] xfs: always hold the iolock when calling xfs_change_file

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 3/5] xfs: always hold the iolock when calling xfs_change_file_space
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Fri, 25 Jan 2013 16:57:11 -0600
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20121208121006.098660509@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20121208120812.755863148@xxxxxxxxxxxxxxxxxxxxxx> <20121208121006.098660509@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 12/08/12 06:08, Christoph Hellwig wrote:

Currently fallocate always holds the iolock when calling into
xfs_change_file_space, while the ioctl path lets some of the lower level
functions take it, but leave it out in others.

This patch makes sure the ioctl path also always holds the iolock and
thus introduces consistent locking for the preallocation operations while
simplifying the code and allowing to kill the now unused XFS_ATTR_NOLOCK
flag.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>


A first for me, seeing you ADD a lock. :)

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 3/5] xfs: always hold the iolock when calling xfs_change_file_space, Mark Tinguely <=

Previous by Date:	Re: [PATCH 2/5] xfs: always take the iolock around xfs_setattr_size, Mark Tinguely
Next by Date:	Re: [RESEND][PATCH 2/2 v2] ext4: let us fully support punching hole feature in fallocate, Dave Chinner
Previous by Thread:	Re: [PATCH 2/5] xfs: always take the iolock around xfs_setattr_size, Mark Tinguely
Next by Thread:	Re: [RESEND][PATCH 2/2 v2] ext4: let us fully support punching hole feature in fallocate, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]