Re: [PATCH] xfsprogs: remove setfl from xfs_io

[Mark Tinguely <tinguely@xxxxxxx>]

On 12/08/12 15:03, Eric Sandeen wrote:
> Doesn't seem to have worked for ages, and is (therefore)
> apparently not ever used:
>
> xfs_io>  setfl
> xfs_io>  help setfl
> setfl [-adx] -- set/clear append/direct flags on the open file
> xfs_io>  setfl -a
> bad argument count 1 to setfl, expected 0 arguments
> xfs_io>  setfl -d
> bad argument count 1 to setfl, expected 0 arguments
> xfs_io>  setfl
> xfs_io>
>
> At best, it seems intended to toggle the flag state, but
> gives no feedback about current state.  -x is in help but
> not implemented, etc.
>
> Just remove it.
>
> Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
> ---
I heard no objections to removing it ...

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>