| To: | Jeff Liu <jeff.liu@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: stop using simple_strtoul() |
| From: | Abhijit Pawar <abhi.c.pawar@xxxxxxxxx> |
| Date: | Tue, 08 Jan 2013 20:45:10 +0530 |
| Cc: | Ben Myers <bpm@xxxxxxx>, Abhijit Pawar <abhi.c.pawar@xxxxxxxxx>, xfs@xxxxxxxxxxx |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=6G1cYMVYlP2tFZmwWj62zYaSLScfs/qdSjOHdLbW/H4=; b=q0jzF4pLsmBivreGbYZGTKYXSts1PWXyucVdvpoMB2lkfSfbvgjQ3wEyu9lLdqNAHp v3/lvVioqQPLt/KQbdBJKA1gZ+Ek3z8WCS+5ewFmId7eEPwR9tJcii7pDUczhV5vD0qk USvKQ4WxKTP9XMxOQUJGpVncT6vhs5yEnjbWgM5/pLPvk9hTRKBeoJiVCYoxlVSMQK7l gp2f44LZfXyCt/OCq1s06zgwLIU4Wmx8h/aC1wNNZwidzXqXJQazpgNnQyOtYipk6XW3 7fYaIb4uKf5oAGJ1COJlQpZw61UGQ9PEx/wsFdAZcGnQgqGjCAJ7nJiwCQ0kGvf8H512 9H8w== |
| In-reply-to: | <50EBC8E5.9080200@xxxxxxxxxx> |
| References: | <50E8F470.5020305@xxxxxxxxxx> <20130107204957.GT27055@xxxxxxx> <50EBC8E5.9080200@xxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
Hi Jeff, On 01/08/2013 12:51 PM, Jeff Liu wrote: > Hi Ben and Abhijit, > > On 01/08/2013 04:49 AM, Ben Myers wrote: >> Hey Jeff & Abhijit, >> >> On Sun, Jan 06, 2013 at 11:50:08AM +0800, Jeff Liu wrote: >>> This small patch convert xfs_parseargs() and suffix_strtoul() to >>> use kstrtoint() instead of simple_strtoul() which is deprecated. >> >> It looks like Jeff's patch will conflict with a patch from Abhijit Pawar, >> 'fs: >> remove obsolete simple_strto<foo>' which we saw Dec 7. You guys went after >> the >> same thing and came up with slightly differing results. If Abhijit would >> prefer to factor out the xfs changes I'd be happy to take either that, or >> Jeff's patch, but it would be better if they didn't conflict. Can y'all come >> to an agreement as to what the xfs changes should be? > Sorry, I missed that patch from Abhijit. > > Looks the previous patch did not replaced the simple_strtoul() with > kstrtoint() in suffix_strtoul(). > > Abhijit, would you like to fix it as well? Yes,it did not replace the call. Looks like I have missed that piece of code. Once Ben applies my original patch, I will send another patch for this on top of that. > > Thanks, > -Jeff > -- - Abhijit |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | ShoesForCrews.com all sales best offers, M john Thomas |
|---|---|
| Next by Date: | Re: [PATCH] xfs: stop using simple_strtoul(), Ben Myers |
| Previous by Thread: | Re: [PATCH] xfs: stop using simple_strtoul(), Jeff Liu |
| Next by Thread: | Re: [PATCH] xfs: stop using simple_strtoul(), Ben Myers |
| Indexes: | [Date] [Thread] [Top] [All Lists] |