| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 08/32] xfs: make growfs initialise the AGFL header |
| From: | Rich Johnston <rjohnston@xxxxxxx> |
| Date: | Tue, 13 Nov 2012 15:18:53 -0600 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <1352721264-3700-9-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1352721264-3700-1-git-send-email-david@xxxxxxxxxxxxx> <1352721264-3700-9-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 |
On 11/12/2012 05:54 AM, Dave Chinner wrote: From: Dave Chinner <dchinner@xxxxxxxxxx> For verification purposes, AGFLs need to be initialised to a known set of values. For upcoming CRC changes, they are also headers that need to be initialised. Currently, growfs does neither for the AGFLs - it ignores them completely. Add initialisation of the AGFL to be full of invalid block numbers (NULLAGBLOCK) to put the infrastructure in place needed for CRC support. Includes a comment clarification from Jeff Liu. Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> --- fs/xfs/xfs_fsops.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) Looks good. Reviewed-by Rich Johnston <rjohnston@xxxxxxx> --Rich |
| Previous by Date: | Re: [PATCH 07/32] xfs: growfs: use uncached buffers for new headers, Rich Johnston |
|---|---|
| Next by Date: | Re: [PATCH 0/3] xfs: fixes for 3.7-rc6, Ben Myers |
| Previous by Thread: | [PATCH 08/32] xfs: make growfs initialise the AGFL header, Dave Chinner |
| Next by Thread: | Re: [PATCH 08/32] xfs: make growfs initialise the AGFL header, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |