Re: [PATCH 06/32] xfs: use btree block initialisation functions in growf

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 06/32] xfs: use btree block initialisation functions in growfs
From:	Rich Johnston <rjohnston@xxxxxxx>
Date:	Tue, 13 Nov 2012 15:18:39 -0600
Cc:	<xfs@xxxxxxxxxxx>
In-reply-to:	<1352721264-3700-7-git-send-email-david@xxxxxxxxxxxxx>
References:	<1352721264-3700-1-git-send-email-david@xxxxxxxxxxxxx> <1352721264-3700-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0

On 11/12/2012 05:53 AM, Dave Chinner wrote:

From: Dave Chinner <dchinner@xxxxxxxxxx>

Factor xfs_btree_init_block() to be independent of the btree cursor,
and use the function to initialise btree blocks in the growfs code.
This makes adding support for different format btree blocks simple.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---
  fs/xfs/xfs_btree.c |   33 ++++++++++++++++++++++++---------
  fs/xfs/xfs_btree.h |   11 +++++++++++
  fs/xfs/xfs_fsops.c |   37 +++++++++++++------------------------
  3 files changed, 48 insertions(+), 33 deletions(-)


Looks good.

Reviewed-by Rich Johnston <rjohnston@xxxxxxx>

--Rich

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 12/32] xfs: verify AGF blocks as they are read from disk, (continued) Re: [PATCH 12/32] xfs: verify AGF blocks as they are read from disk, Phil White Re: [PATCH 12/32] xfs: verify AGF blocks as they are read from disk, Dave Chinner [PATCH 12/32 V2] xfs: verify AGF blocks as they are read from disk, Dave Chinner Re: [PATCH 12/32 V2] xfs: verify AGF blocks as they are read from disk, Mark Tinguely [PATCH 09/32] xfs: make buffer read verication an IO completion function, Dave Chinner [PATCH 11/32] xfs: verify superblocks as they are read from disk, Dave Chinner Re: [PATCH 11/32] xfs: verify superblocks as they are read from disk, Christoph Hellwig [PATCH 14/32] xfs: verify AGFL blocks as they are read from disk, Dave Chinner [PATCH 13/32] xfs: verify AGI blocks as they are read from disk, Dave Chinner [PATCH 06/32] xfs: use btree block initialisation functions in growfs, Dave Chinner Re: [PATCH 06/32] xfs: use btree block initialisation functions in growfs, Rich Johnston <= Re: [PATCH 06/32] xfs: use btree block initialisation functions in growfs, Christoph Hellwig Re: [PATCH 06/32] xfs: use btree block initialisation functions in growfs, Dave Chinner [PATCH 22/32] xfs: factor out dir2 data block reading, Dave Chinner [PATCH 23/32] xfs: factor dir2 leaf read, Dave Chinner [PATCH 05/32] xfs: remove xfs_flushinval_pages, Dave Chinner Re: [PATCH 05/32] xfs: remove xfs_flushinval_pages, Christoph Hellwig Re: [PATCH 05/32] xfs: remove xfs_flushinval_pages, Dave Chinner Re: [PATCH 05/32] xfs: remove xfs_flushinval_pages, Christoph Hellwig [PATCH 15/32] xfs: verify inode buffers as they are read from disk, Dave Chinner [PATCH 27/32] xfs: add buffer pre-write callback, Dave Chinner

Previous by Date:	[XFS updates] XFS development tree branch, for-next, updated. v3.7-rc1-40-gee73259, xfs
Next by Date:	Re: [PATCH 07/32] xfs: growfs: use uncached buffers for new headers, Rich Johnston
Previous by Thread:	[PATCH 06/32] xfs: use btree block initialisation functions in growfs, Dave Chinner
Next by Thread:	Re: [PATCH 06/32] xfs: use btree block initialisation functions in growfs, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]