Re: [PATCH 4/6] xfs: don't vmap inode cluster buffers during free

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 4/6] xfs: don't vmap inode cluster buffers during free
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Fri, 02 Nov 2012 16:24:09 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1351816724-3000-5-git-send-email-david@xxxxxxxxxxxxx>
References:	<1351816724-3000-1-git-send-email-david@xxxxxxxxxxxxx> <1351816724-3000-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 11/01/12 19:38, Dave Chinner wrote:

From: Dave Chinner<dchinner@xxxxxxxxxx>

Inode buffers do not need to be mapped as inodes are read or written
directly from/to the pages underlying the buffer. This fixes a
regression introduced by commit 611c994 ("xfs: make XBF_MAPPED the
default behaviour").

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---



Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/6] xfs: fixes for 3.7-rc3, Dave Chinner [PATCH 1/6] xfs: silence uninitialised f.file warning., Dave Chinner Re: [PATCH 1/6] xfs: silence uninitialised f.file warning., Christoph Hellwig Re: [PATCH 1/6] xfs: silence uninitialised f.file warning., Mark Tinguely [PATCH 2/6] xfs: growfs: don't read garbage for new secondary superblocks, Dave Chinner [PATCH 4/6] xfs: don't vmap inode cluster buffers during free, Dave Chinner Re: [PATCH 4/6] xfs: don't vmap inode cluster buffers during free, Christoph Hellwig Re: [PATCH 4/6] xfs: don't vmap inode cluster buffers during free, Mark Tinguely <= [PATCH 3/6] xfs: invalidate allocbt blocks moved to the free list, Dave Chinner Re: [PATCH 3/6] xfs: invalidate allocbt blocks moved to the free list, Mark Tinguely [PATCH 6/6] xfs: fix reading of wrapped log data, Dave Chinner Re: [PATCH 6/6] xfs: fix reading of wrapped log data, Christoph Hellwig Re: [PATCH 6/6] xfs: fix reading of wrapped log data, Dave Chinner Re: [PATCH 6/6] xfs: fix reading of wrapped log data, Mark Tinguely [PATCH 5/6] xfs: fix buffer shudown reference count mismatch, Dave Chinner Re: [PATCH 5/6] xfs: fix buffer shudown reference count mismatch, Dave Chinner [PATCH 5/6 V2] xfs: fix buffer shudown reference count mismatch, Dave Chinner Re: [PATCH 5/6 V2] xfs: fix buffer shudown reference count mismatch, Mark Tinguely

Previous by Date:	Re: [PATCH 3/6] xfs: invalidate allocbt blocks moved to the free list, Mark Tinguely
Next by Date:	Re: [PATCH 6/6] xfs: fix reading of wrapped log data, Mark Tinguely
Previous by Thread:	Re: [PATCH 4/6] xfs: don't vmap inode cluster buffers during free, Christoph Hellwig
Next by Thread:	[PATCH 3/6] xfs: invalidate allocbt blocks moved to the free list, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]