xfs
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH v2] xfsprog: remove duplicate vector memalign from xfs_io

from [Mark Tinguely] [Permanent Link][Original]
To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2] xfsprog: remove duplicate vector memalign from xfs_io
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 28 Sep 2012 11:38:42 -0500
Cc: xfs@xxxxxxxxxxx, Ben Myers <bpm@xxxxxxx>
In-reply-to: <20120927225248.GB25626@dastard>
References: <20120925142414.660506845@xxxxxxx> <20120925142421.398175185@xxxxxxx> <20120926220434.GG13214@xxxxxxx> <20120927124742.695778439@xxxxxxx> <20120927225248.GB25626@dastard>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 
On 09/27/12 17:52, Dave Chinner wrote:

On Thu, Sep 27, 2012 at 07:47:36AM -0500, Mark Tinguely wrote:

The vector feature of xfs_io uses its own memory buffer in the iov structure
and does not use the buffer entry. Remove the duplicate memalign.

v2: removed global buffer in __dump_buffer() and use passed buf pointer per
     Ben's detection.

Signed-off-by: Mark Tinguely<tinguely@xxxxxxx>
Reviewed-by: Ben Myers<bpm@xxxxxxx>


Looks good, Thanks for fixing this.

Reviewed-by: Dave Chinner<dchinner@xxxxxxxxxx>




Committed to git://oss.sgi.com/xfs/cmds/xfsprogs.git, master branch.

--Mark.
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH] xfs: only update the last_sync_lsn when a transaction completes, Christoph Hellwig
Next by Date:  Uw vriend(in) 1 .......Crazy $600 per day with MOBILE...................................................................... raad dit artikel aan EuroShopGigant - Alles voor in huis en tuin - SCHERPE prijzen, 1 .......Crazy $600 per day with MOBILE......................................................................
Previous by Thread:  Re: [PATCH v2] xfsprog: remove duplicate vector memalign from xfs_io, Dave Chinner
Next by Thread:  Re: [PATCH] xfsprog: remove duplicate vector memalign from xfs_io, Dave Chinner
Indexes:  [Date] [Thread] [Top] [All Lists]