| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 03/13] xfs: rationalise xfs_mount_wq users |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Tue, 11 Sep 2012 16:25:41 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1346328017-2795-4-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1346328017-2795-1-git-send-email-david@xxxxxxxxxxxxx> <1346328017-2795-4-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 08/30/12 07:00, Dave Chinner wrote: From: Dave Chinner<dchinner@xxxxxxxxxx> Instead of starting and stopping background work on the xfs_mount_wq all at the same time, separate them to where they really are needed to start and stop. The xfs_sync_worker, only needs to be started after all the mount processing has completed successfully, while it needs to be stopped before the log is unmounted. The xfs_reclaim_worker is started on demand, and can be stopped before the unmount process does it's own inode reclaim pass. The xfs_flush_inodes work is run on demand, and so we really only need to ensure that it has stopped running before we start processing an unmount, freeze or remount,ro. Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx> --- The patch itself looks good. and the "atomic_read(&bp->b_hold)> 0" assert appears specific to my machines, so forgive the noise. Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v5] Stop xfs_do_force_shutdown / messages fron xfs_log_force if filesystem is already shutdown., Dave Chinner |
|---|---|
| Next by Date: | [PATCH V2 0/3] Print when ENOSPC due to lack of inodes in non-inode64 mount., raghu . prabhu13 |
| Previous by Thread: | Re: [PATCH 03/13] xfs: rationalise xfs_mount_wq users, Dave Chinner |
| Next by Thread: | Re: [PATCH 0/5] Use libtool to install apps and remove relative lib paths, Ben Myers |
| Indexes: | [Date] [Thread] [Top] [All Lists] |