| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 06/13] xfs: Bring some sanity to log unmounting |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Tue, 04 Sep 2012 14:11:29 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1346328017-2795-7-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1346328017-2795-1-git-send-email-david@xxxxxxxxxxxxx> <1346328017-2795-7-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 08/30/12 07:00, Dave Chinner wrote: From: Dave Chinner<dchinner@xxxxxxxxxx> When unmounting the filesystem, there are lots of operations that need to be done in a specific order, and they are spread across across a couple of functions. We have to drain the AIL before we write the unmount record, and we have to shut down the background log work before we do either of them. But this is all split haphazardly across xfs_unmountfs() and xfs_log_unmount(). Move all the AIL flushing and log manipulations to xfs_log_unmount() so that the responisbilities of each function is clear and the operations they perform obvious. Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx> --- Looks good. Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 05/13] xfs: sync work is now only periodic log work, Mark Tinguely |
|---|---|
| Next by Date: | Re: [PATCH 07/13] xfs: xfs_sync_data is redundant., Mark Tinguely |
| Previous by Thread: | Re: [PATCH 06/13] xfs: Bring some sanity to log unmounting, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 10/13] xfs: xfs_quiesce_attr() should quiesce the log like unmount, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |