Re: [PATCH 1/5] xfs: clean up xfs_inactive

[Rich Johnston <rjohnston@xxxxxxx>]

On 07/04/2012 10:13 AM, Christoph Hellwig wrote:
> The code to reserve log space and join the inode to the transaction is
> common for all cases, so don't duplicate it.  Also remove the trivial
> xfs_inactive_symlink_local helper which can simply be opencode now.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>
> ---
>  fs/xfs/xfs_vnodeops.c |  171 ++++++++++++--------------------------------------
>  1 file changed, 43 insertions(+), 128 deletions(-)
As stated this patch cleans up duplicate code and removed local helper 
function.  Looks good.
Reviewed-by:    Rich Johnston <rjohnston@xxxxxxx>