Re: [PATCH 02/37] xfs: remove log item from AIL in xfs

xfs

Re: [PATCH 02/37] xfs: remove log item from AIL in xfs_iflush after a sh

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 02/37] xfs: remove log item from AIL in xfs_iflush after a shutdown
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Mon, 23 Apr 2012 10:39:48 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1335160747-17254-3-git-send-email-david@xxxxxxxxxxxxx>
References:	<1335160747-17254-1-git-send-email-david@xxxxxxxxxxxxx> <1335160747-17254-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 04/23/12 00:58, Dave Chinner wrote:

From: Christoph Hellwig<hch@xxxxxxxxxxxxx>

If a filesystem has been forced shutdown we are never going to write inodes
to disk, which means the inode items will stay in the AIL until we free
the inode. Currently that is not a problem, but a pending change requires us
to empty the AIL before shutting down the filesystem. In that case leaving
the inode in the AIL is lethal. Make sure to remove the log item from the AIL
to allow emptying the AIL on shutdown filesystems.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>
Reviewed-by: Dave Chinner<dchinner@xxxxxxxxxx>
---



Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/37] xfs: current 3.4 patch queue, Dave Chinner [PATCH 01/37] xfs: remove log item from AIL in xfs_qm_dqflush after a shutdown, Dave Chinner [PATCH 07/37] xfs: do not write the buffer from xfs_qm_dqflush, Dave Chinner [PATCH 05/37] xfs: don't flush inodes from background inode reclaim, Dave Chinner [PATCH 03/37] xfs: allow assigning the tail lsn with the AIL lock held, Dave Chinner [PATCH 02/37] xfs: remove log item from AIL in xfs_iflush after a shutdown, Dave Chinner Re: [PATCH 02/37] xfs: remove log item from AIL in xfs_iflush after a shutdown, Mark Tinguely <= [PATCH 08/37] xfs: do not add buffers to the delwri queue until pushed, Dave Chinner [PATCH 04/37] xfs: implement freezing by emptying the AIL, Dave Chinner Re: [PATCH 04/37] xfs: implement freezing by emptying the AIL, Mark Tinguely Re: [PATCH 04/37] xfs: implement freezing by emptying the AIL, Christoph Hellwig [PATCH 10/37] xfs: remove some obsolete comments in xfs_trans_ail.c, Dave Chinner Re: [PATCH 10/37] xfs: remove some obsolete comments in xfs_trans_ail.c, Mark Tinguely [PATCH 17/37] xfs: fix incorrect b_offset initialisation, Dave Chinner [PATCH 12/37] xfs: Do background CIL flushes via a workqueue, Dave Chinner [PATCH 12/37 V2] xfs: Do background CIL flushes via a workqueue, Dave Chinner Re: [PATCH 12/37 V2] xfs: Do background CIL flushes via a workqueue, Christoph Hellwig

Previous by Date:	Re: Still seeing hangs in xlog_grant_log_space, Juerg Haefliger
Next by Date:	Re: [PATCH 04/37] xfs: implement freezing by emptying the AIL, Mark Tinguely
Previous by Thread:	[PATCH 02/37] xfs: remove log item from AIL in xfs_iflush after a shutdown, Dave Chinner
Next by Thread:	[PATCH 08/37] xfs: do not add buffers to the delwri queue until pushed, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]