Re: [PATCH 15/18] xfs: kill XBF

xfs

Re: [PATCH 15/18] xfs: kill XBF_LOCK

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 15/18] xfs: kill XBF_LOCK
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Fri, 13 Apr 2012 16:20:29 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1334319061-12968-16-git-send-email-david@xxxxxxxxxxxxx>
References:	<1334319061-12968-1-git-send-email-david@xxxxxxxxxxxxx> <1334319061-12968-16-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 04/13/12 07:10, Dave Chinner wrote:

From: Dave Chinner<dchinner@xxxxxxxxxx>

Buffers are always returned locked from the lookup routines. Hence
we don't need to tell the lookup routines to return locked buffers,
on to try and lock them. Remove XBF_LOCK from all the callers and
from internal buffer cache usage.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
Reviewed-by: Christoph Hellwig<hch@xxxxxx>
---


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 03/18] xfs: Do background CIL flushes via a workqueue, (continued) Re: [PATCH 03/18] xfs: Do background CIL flushes via a workqueue, Dave Chinner Re: [PATCH 03/18] xfs: Do background CIL flushes via a workqueue, Dave Chinner [PATCH 07/18] xfs: check for buffer errors before waiting, Dave Chinner Re: [PATCH 07/18] xfs: check for buffer errors before waiting, Mark Tinguely [PATCH 14/18] xfs: kill xfs_buf_btoc, Dave Chinner [PATCH 12/18] xfs: use blocks for counting length of buffers, Dave Chinner [PATCH 16/18] xfs: kill xfs_read_buf(), Dave Chinner [PATCH 17/18] xfs: kill XBF_DONTBLOCK, Dave Chinner Re: [PATCH 17/18] xfs: kill XBF_DONTBLOCK, Mark Tinguely [PATCH 15/18] xfs: kill XBF_LOCK, Dave Chinner Re: [PATCH 15/18] xfs: kill XBF_LOCK, Mark Tinguely <= [PATCH 11/18] xfs: kill b_file_offset, Dave Chinner [PATCH 18/18] xfs: use iolock on XFS_IOC_ALLOCSP calls, Dave Chinner Re: [PATCH 18/18] xfs: use iolock on XFS_IOC_ALLOCSP calls, Mark Tinguely Re: [PATCH 0/18] xfs: current patch queue, Ben Myers Re: [PATCH 0/18] xfs: current patch queue, Dave Chinner Re: [PATCH 0/18] xfs: current patch queue, Ben Myers

Previous by Date:	Re: XFS: Abysmal write performance because of excessive seeking (allocation groups to blame?), Stefan Ring
Next by Date:	Re: [PATCH 02/18] xfs: pass shutdown method into xfs_trans_ail_delete_bulk, Dave Chinner
Previous by Thread:	[PATCH 15/18] xfs: kill XBF_LOCK, Dave Chinner
Next by Thread:	[PATCH 11/18] xfs: kill b_file_offset, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]