Re: [PATCH 1/3] xfs: kill XBF_LOCK

[Mark Tinguely <tinguely@xxxxxxx>]

On 04/11/12 15:07, Christoph Hellwig wrote:
> On Wed, Apr 11, 2012 at 08:20:27AM +1000, Dave Chinner wrote:
> > > The reason I ask, the sources that I have for xfs_buf_get() seems to
> > > still have a "goto no_buffer" for the failed
> > > xfs_buf_allocate_memory() call and this patch removes that call. I
> > > did not find anything in the 8 buf clean-up series that would alter
> > > this area.
> > I'm sure I posted it previously. Let me update all the reviewed-by
> > tags and I'll resend the entire series....
> I think Mark meant the patch to fix the error handling for failed
> allocation, which needs to be redone to only insert the buffer into the
> rbtree once it's fully set up.
>
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
That is correct.

The series in general looked good to me.

--Mark Tinguely.