Re: [PATCH 1/5] xfs: avoid taking the ilock unnessecarily in xfs_qm

xfs

Re: [PATCH 1/5] xfs: avoid taking the ilock unnessecarily in xfs_qm_dqat

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 1/5] xfs: avoid taking the ilock unnessecarily in xfs_qm_dqattach
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Mon, 02 Apr 2012 14:24:59 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20120327143826.255746245@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20120327143445.196524266@xxxxxxxxxxxxxxxxxxxxxx> <20120327143826.255746245@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 03/27/12 09:34, Christoph Hellwig wrote:

Check if we actually need to attach a dquot before taking the ilock in
xfs_qm_dqattach.  This avoid superflous lock roundtrips for the common cases
of quota support compiled in but not activated on a filesystem and an
inode that already has the dquots attached.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 1/5] xfs: avoid taking the ilock unnessecarily in xfs_qm_dqattach, Mark Tinguely <=

Previous by Date:	Re: [RFC] Add XFS support in SYSLINUX, Christoph Hellwig
Next by Date:	Re: [PATCH 2/5] xfs: reduce ilock hold times in xfs_file_aio_write_checks, Mark Tinguely
Previous by Thread:	Re: [PATCH] xfs: don't fill statvfs with project quota for a directory if it was not enabled., Christoph Hellwig
Next by Thread:	Re: [PATCH 2/5] xfs: reduce ilock hold times in xfs_file_aio_write_checks, Mark Tinguely
Indexes:	[Date] [Thread] [Top] [All Lists]