Re: [PATCH 01/10] xfs: remove log item from AIL in xfs_qm

xfs

Re: [PATCH 01/10] xfs: remove log item from AIL in xfs_qm_dqflush after

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 01/10] xfs: remove log item from AIL in xfs_qm_dqflush after a shutdown
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Tue, 27 Mar 2012 13:17:30 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20120327164644.243162639@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20120327164400.967415009@xxxxxxxxxxxxxxxxxxxxxx> <20120327164644.243162639@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 03/27/12 11:44, Christoph Hellwig wrote:

If a filesystem has been forced shutdown we are never going to write dquots
to disk, which means the dquot items will stay in the AIL forever.
Currently that is not a problem, but a pending chance requires us to
empty the AIL before shutting down the filesystem, in which case this
behaviour is lethal.  Make sure to remove the log item from the AIL
to allow emptying the AIL on shutdown filesystems.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/10] remove xfsbufd, Christoph Hellwig [PATCH 02/10] xfs: remove log item from AIL in xfs_iflush after a shutdown, Christoph Hellwig [PATCH 01/10] xfs: remove log item from AIL in xfs_qm_dqflush after a shutdown, Christoph Hellwig Re: [PATCH 01/10] xfs: remove log item from AIL in xfs_qm_dqflush after a shutdown, Mark Tinguely <= [PATCH 03/10] xfs: allow assigning the tail lsn with the AIL lock held, Christoph Hellwig Re: [PATCH 03/10] xfs: allow assigning the tail lsn with the AIL lock held, Mark Tinguely [PATCH 04/10] xfs: implement freezing by emptying the AIL, Christoph Hellwig [PATCH 05/10] xfs: do flush inodes from background inode reclaim, Christoph Hellwig [PATCH 06/10] xfs: do not write the buffer from xfs_iflush, Christoph Hellwig [PATCH 07/10] xfs: do not write the buffer from xfs_qm_dqflush, Christoph Hellwig [PATCH 10/10] xfs: remove some obsolete comments in xfs_trans_ail.c, Christoph Hellwig [PATCH 08/10] xfs: do not add buffers to the delwri queue until pushed, Christoph Hellwig [PATCH 09/10] xfs: on-stack delayed write buffer lists, Christoph Hellwig Re: [PATCH 00/10] remove xfsbufd, Dave Chinner

Previous by Date:	Re: [PATCH] xfs: Do background CIL flushes via a workqueue, Vivek Goyal
Next by Date:	Re: [PATCH 03/10] xfs: allow assigning the tail lsn with the AIL lock held, Mark Tinguely
Previous by Thread:	[PATCH 01/10] xfs: remove log item from AIL in xfs_qm_dqflush after a shutdown, Christoph Hellwig
Next by Thread:	[PATCH 03/10] xfs: allow assigning the tail lsn with the AIL lock held, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]