Re: [PATCH 02/10] xfs: Fix open flag handling in open_by

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 02/10] xfs: Fix open flag handling in open_by_handle code
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Tue, 13 Mar 2012 16:15:37 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1331095828-28742-3-git-send-email-david@xxxxxxxxxxxxx>
References:	<1331095828-28742-1-git-send-email-david@xxxxxxxxxxxxx> <1331095828-28742-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 03/06/12 22:50, Dave Chinner wrote:

From: Dave Chinner<dchinner@xxxxxxxxxx>

Sparse identified some unsafe handling of open flags in the xfs open
by handle ioctl code. Update the code to use the correct access
macros to ensure that we handle the open flags correctly.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 10/10] xfs: don't cache inodes read through bulkstat, (continued) [PATCH 10/10] xfs: don't cache inodes read through bulkstat, Dave Chinner Re: [PATCH 10/10] xfs: don't cache inodes read through bulkstat, Christoph Hellwig Re: [PATCH 10/10] xfs: don't cache inodes read through bulkstat, Ben Myers Re: [PATCH 10/10] xfs: don't cache inodes read through bulkstat, Ben Myers Re: [PATCH 10/10] xfs: don't cache inodes read through bulkstat, Dave Chinner [PATCH 01/10] xfs: clean up minor sparse warnings, Dave Chinner Re: [PATCH 01/10] xfs: clean up minor sparse warnings, Ben Myers Re: [PATCH 01/10] xfs: clean up minor sparse warnings, Dave Chinner [PATCH 02/10] xfs: Fix open flag handling in open_by_handle code, Dave Chinner Re: [PATCH 02/10] xfs: Fix open flag handling in open_by_handle code, Christoph Hellwig Re: [PATCH 02/10] xfs: Fix open flag handling in open_by_handle code, Mark Tinguely <= [PATCH 06/10] xfs: remove remaining scraps of struct xfs_iomap, Dave Chinner Re: [PATCH 06/10] xfs: remove remaining scraps of struct xfs_iomap, Mark Tinguely [PATCH 07/10] xfs: fix inode lookup race, Dave Chinner [PATCH 08/10] xfs: initialise xfssync work before running quotachecks, Dave Chinner Re: [PATCH 08/10] xfs: initialise xfssync work before running quotachecks, Christoph Hellwig Re: [PATCH 08/10] xfs: initialise xfssync work before running quotachecks, Mark Tinguely [PATCH 04/10] xfs: fallback to vmalloc for large buffers in xfs_getbmap, Dave Chinner Re: [PATCH 04/10] xfs: fallback to vmalloc for large buffers in xfs_getbmap, Christoph Hellwig Re: [PATCH 04/10] xfs: fallback to vmalloc for large buffers in xfs_getbmap, Mark Tinguely [PATCH 09/10] xfs: remove MS_ACTIVE guard from inode reclaim work, Dave Chinner

Previous by Date:	Re: [PATCH 0/5] quota updates V4, Ben Myers
Next by Date:	Re: [PATCH 11/19] xfs: Convert to new freezing code, Jan Kara
Previous by Thread:	Re: [PATCH 02/10] xfs: Fix open flag handling in open_by_handle code, Christoph Hellwig
Next by Thread:	[PATCH 06/10] xfs: remove remaining scraps of struct xfs_iomap, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 02/10] xfs: Fix open flag handling in open_by_handle code