| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/8] xfsprogs: xfs_repair: don't set the root inode pointer |
| From: | Kevan Rehm <kfr@xxxxxxx> |
| Date: | Tue, 07 Feb 2012 14:25:35 -0600 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20120207183830.GA31143@xxxxxxxxxxxxx> |
| References: | <3ed89446f6dc1231ec1de712f242522052952b7e.1320955675.git.aelder@xxxxxxx> <6833e89ecf7daa3ba69676fb98a4538ee6c3a1b5.1320955675.git.aelder@xxxxxxx> <20111113120133.GC19435@xxxxxxxxxxxxx> <20120207183830.GA31143@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110414 SUSE/3.1.10 Lightning/1.0b2 Thunderbird/3.1.10 |
On 02/07/2012 12:38 PM, Christoph Hellwig wrote: On Sun, Nov 13, 2011 at 07:01:33AM -0500, Christoph Hellwig wrote:On Thu, Nov 10, 2011 at 02:35:13PM -0600, Alex Elder wrote:From: Kevan Rehm<kfr@xxxxxxx> In phase 6, in mk_root_dir(), xfs_repair initializes the mount point's m_rootip pointer without accounting for that reference. This field never really used or needed in repair otherwise, and the assigned pointer doesn't really represent a real reference to an inode that needs to be cached. So just kill off this assignment. Signed-off-by: Alex Elder<aelder@xxxxxxx>Shouldn't this also have Kevan's signoff?Kevan, can you give me a signoff for this patch, I'd like to put it in? Fine by me. Kevan |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | xfs_repair, xfs_metadump trouble with fs, Keith Keller |
|---|---|
| Next by Date: | Re: [PATCH 3/3] filemap: don't call generic_write_sync for -EIOCBQUEUED, Jeff Moyer |
| Previous by Thread: | Re: [PATCH 3/8] xfsprogs: xfs_repair: don't set the root inode pointer, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 3/8] xfsprogs: xfs_repair: don't set the root inode pointer, Kevan Rehm |
| Indexes: | [Date] [Thread] [Top] [All Lists] |