Re: [PATCH] xfsprogs: check for size parsing errors in xfs_quota

[Eric Sandeen <sandeen@xxxxxxxxxx>]

On 1/24/12 11:56 AM, Christoph Hellwig wrote:
>> -            v = (__uint64_t)cvtnum(blocksize, sectorsize, s);
>> -            *value = v >> 9;        /* syscalls use basic blocks */
>> +            v = cvtnum(blocksize, sectorsize, s);
>> +            if (v == -1LL) {
>> +                    fprintf(stderr, _("%s: Error: could not parse size 
>> %s.\n"), progname, s);
>> +                    return 0;
>> +            }
>> +            *value = (__uint64_t)v >> 8;    /* syscalls use basic blocks */
> 
> Why do you replace the shift by nine with a shift by 8?

yeargh, NFI - vi gone wild?

> Also please don't introduce new overly long lines, just move the
> translated string to a line of its own, indented by a single tab similar
> to how we do it in most new xfs/xfsprogs code.

Ok, sure, sorry.  TBH I noticed it but there was such a long line below
I didn't worry.  Will resend.

-Eric