| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfsprogs: check for size parsing errors in xfs_quota |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Mon, 23 Jan 2012 23:07:35 -0600 |
| Cc: | Eric Sandeen <sandeen@xxxxxxxxxx>, James Lawrie <james@xxxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20120123195922.GA2366@xxxxxxxxxxxxx> |
| References: | <4F1D9989.8060808@xxxxxxxxxx> <20120123195922.GA2366@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 |
On 1/23/12 1:59 PM, Christoph Hellwig wrote: > On Mon, Jan 23, 2012 at 11:31:53AM -0600, Eric Sandeen wrote: >> Doing something like >> >> # xfs_quota -x -c 'limit -u bhard=1.2g ... >> >> will cause cvtnum to fail and return a value of -1LL (because it >> cannot parse the decimal), but the quota caller doesn't check >> for this error value, casts it to U64, shifts right, and we end >> up with an answer of 16 petabytes rather than erroring out. >> Fix this. > > Can you add a test case for it, please? sure... I have quite a backlog of tests I need to get pushed to git :( Is that an ack for the patch, though? :) -Eric |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: log recovery fails at mount, Eric Sandeen |
|---|---|
| Next by Date: | Sua mensagem para a lista Tribuna aguarda aprovação, tribuna-bounces |
| Previous by Thread: | Re: [PATCH] xfsprogs: check for size parsing errors in xfs_quota, Christoph Hellwig |
| Next by Thread: | Re: [PATCH] xfsprogs: check for size parsing errors in xfs_quota, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |