xfs
[Top] [All Lists]

Re: [PATCH] xfstests: mount other filesystems with selinux context as we

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: mount other filesystems with selinux context as well
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 19 Jan 2012 12:37:48 -0600
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, ext4 development <linux-ext4@xxxxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20111128110228.GC13766@xxxxxxxxxxxxx>
References: <4ECD3262.105@xxxxxxxxxx> <20111128110228.GC13766@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20111222 Thunderbird/9.0.1
On 11/28/11 5:02 AM, Christoph Hellwig wrote:
> On Wed, Nov 23, 2011 at 11:50:26AM -0600, Eric Sandeen wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> For some reason, non-xfs filesystems aren't getting mounted with
>> the selinux context; perhaps because none of the xattr tests used
>> to work on anything but xfs?
>>
>> Anyway, 062 fails for extN unless we mount with the fs-wide
>> context.
>>
>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
>> - ---
>>
>> diff --git a/common.rc b/common.rc
>> index cab0b64..5998ff2 100644
>> - --- a/common.rc
>> +++ b/common.rc
>> @@ -86,14 +86,17 @@ _mount_opts()
>>      export MOUNT_OPTIONS=$NFS_MOUNT_OPTIONS
>>      ;;
>>      ext2|ext3|ext4|ext4dev)
>> - -  # acls & xattrs aren't turned on by default on ext$FOO
>> +    export SELINUX_MOUNT_OPTIONS
>> +    # acls & xattrs aren't turned on by default on ext$FOO in old kernels
>>      export MOUNT_OPTIONS="-o acl,user_xattr $EXT_MOUNT_OPTIONS"
>>      ;;
>>      reiserfs)
>> +    export SELINUX_MOUNT_OPTIONS
>>      # acls & xattrs aren't turned on by default on reiserfs
>>      export MOUNT_OPTIONS="-o acl,user_xattr $REISERFS_MOUNT_OPTIONS"
>>      ;;
>>      gfs2)
>> +    export SELINUX_MOUNT_OPTIONS
>>      # acls aren't turned on by default on gfs2
>>      export MOUNT_OPTIONS="-o acl $GFS2_MOUNT_OPTIONS"
>>      ;;
> 
> shouldn't the "export SELINUX_MOUNT_OPTIONS" simply move to common code?

I wasn't sure if nfs would grok it.

-Eric

<Prev in Thread] Current Thread [Next in Thread>