| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 03/12] repair: allocate and free extent records individually |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Thu, 12 Jan 2012 16:39:47 -0600 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20111202174741.504430987@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20111202174619.179530033@xxxxxxxxxxxxxxxxxxxxxx> <20111202174741.504430987@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.24) Gecko/20111206 Thunderbird/3.1.16 |
On 01/-10/63 13:59, Christoph Hellwig wrote: Instead of allocating inode records in chunks and keeping a freelist of them which gets released to the system memory allocator in one go use plain malloc and free for them. The freelist just means adding a global lock instead of relying on malloc and free which could be implemented lockless. In addition smart allocators like tcmalloc have far less overhead than our chunk and linked list. Looks good. Has been running without issues. Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 02/12] repair: allocate and free inode records individually, Mark Tinguely |
|---|---|
| Next by Date: | HELLO, Donna Martinez |
| Previous by Thread: | Re: [PATCH 02/12] repair: allocate and free inode records individually, Mark Tinguely |
| Next by Thread: | Re: working on extent locks for i_mutex, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |