xfs
[Top] [All Lists]

Re: [PATCH 7/7] mm: vmscan: Immediately reclaim end-of-LRU dirty pages w

To: Mel Gorman <mgorman@xxxxxxx>
Subject: Re: [PATCH 7/7] mm: vmscan: Immediately reclaim end-of-LRU dirty pages when writeback completes
From: Rik van Riel <riel@xxxxxxxxxx>
Date: Fri, 12 Aug 2011 11:27:18 -0400
Cc: Linux-MM <linux-mm@xxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, XFS <xfs@xxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Johannes Weiner <jweiner@xxxxxxxxxx>, Wu Fengguang <fengguang.wu@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Minchan Kim <minchan.kim@xxxxxxxxx>
In-reply-to: <1312973240-32576-8-git-send-email-mgorman@xxxxxxx>
References: <1312973240-32576-1-git-send-email-mgorman@xxxxxxx> <1312973240-32576-8-git-send-email-mgorman@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0
On 08/10/2011 06:47 AM, Mel Gorman wrote:
When direct reclaim encounters a dirty page, it gets recycled around
the LRU for another cycle. This patch marks the page PageReclaim
similar to deactivate_page() so that the page gets reclaimed almost
immediately after the page gets cleaned. This is to avoid reclaiming
clean pages that are younger than a dirty page encountered at the
end of the LRU that might have been something like a use-once page.

Signed-off-by: Mel Gorman<mgorman@xxxxxxx>
Acked-by: Johannes Weiner<jweiner@xxxxxxxxxx>

I'm thinking we may need to add some code to
ClearPageReclaim to mark_page_accessed, but
that would be completely independent of these
patches, so ...

Reviewed-by: Rik van Riel <riel@xxxxxxxxxx>

--
All rights reversed

<Prev in Thread] Current Thread [Next in Thread>