Re: [PATCH 0/4] xfsdump: convert to using the POSIX signal API

[Bill Kendall <wkendall@xxxxxxx>]

Christoph Hellwig wrote:
> On Wed, Aug 03, 2011 at 06:57:37AM -0500, Bill Kendall wrote:
> > Christoph Hellwig wrote:
> > > Bill,
> > >
> > > one thing I noticed looking over the code to understand your changes
> > > is that there still is a lot of dead code in xfsdump.  One that
> > > has a lot of implications and seems fairly useless for any non-IRIX
> > > version is the miniroot mode.  Any chance we can rip that out?  There's
> > Yes, that's being used to disable multi-stream code in the Linux version.
> > The end of my multi-stream patch series removes the miniroot code.
> Ooops, I didn't notice miniroot is actually defined to true.  Now that
> I look deeper that also answers my comment about the duplicate signal
> setup in main - one it's done for the miniroot case, and once for the
> !miniroot case.
>
> Now that we uses EPIPE instead of SIGPIPE is there actually any good
> reason to do this setup in two different places?
Nope, I'll resubmit with this change.

Bill