Re: [PATCH 1/4] xfsdump: remove conditional OPENMASKED code

[Bill Kendall <wkendall@xxxxxxx>]

Christoph Hellwig wrote:
> On Fri, Jul 29, 2011 at 03:40:08PM -0500, Bill Kendall wrote:
> > xfsdump contains a couple wrapper functions which block signals
> > during an open(2) call. This code is conditionally compiled and has
> > not been enabled for a long time. Remove the wrappers rather than
> > converting them to use the POSIX signal API.
> >
> > Signed-off-by: Bill Kendall <wkendall@xxxxxxx>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
> Any idea what this code was used for?  Driver-specific open quirks on
> IRIX?
Not sure, but probably something along those lines. The original
revision in the IRIX tree has the OPENMASKED code, but it too
is not enabled.

Thanks for the review.

Bill