Re: [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong

xfs

Re: [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong

To:	david@xxxxxxxxxxxxx
Subject:	Re: [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong
From:	KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
Date:	Mon, 20 Jun 2011 13:30:29 +0900
Cc:	linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to:	<20110620012531.GN561@dastard>
References:	<1306998067-27659-1-git-send-email-david@xxxxxxxxxxxxx> <1306998067-27659-3-git-send-email-david@xxxxxxxxxxxxx> <4DFE987E.1070900@xxxxxxxxxxxxxx> <20110620012531.GN561@dastard>
User-agent:	Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10

>> Looks great fix. Please remove tracepoint change from this patch and send it
>> to -stable. iow, I expect I'll ack your next spin.
> 
> I don't believe such a change belongs in -stable. This code has been
> buggy for many years and as I mentioned it actually makes existing
> bad shrinker behaviour worse. I don't test stable kernels, so I've
> got no idea what side effects it will have outside of this series.
> I'm extremely hesitant to change VM behaviour in stable kernels
> without having tested first, so I'm not going to push it for stable
> kernels.

Ok, I have no strong opinion.



> 
> If you want it in stable kernels, then you can always let
> stable@xxxxxxxxxx know once the commits are in the mainline tree and
> you've tested them...

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/12] Per superblock cache reclaim, Dave Chinner [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong, Dave Chinner Re: [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong, KOSAKI Motohiro Re: [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong, Dave Chinner Re: [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong, KOSAKI Motohiro <= [PATCH 06/12] inode: Make unused inode LRU per superblock, Dave Chinner Re: [PATCH 06/12] inode: Make unused inode LRU per superblock, Al Viro Re: [PATCH 06/12] inode: Make unused inode LRU per superblock, Dave Chinner [PATCH 01/12] vmscan: add shrink_slab tracepoints, Dave Chinner Re: [PATCH 01/12] vmscan: add shrink_slab tracepoints, KOSAKI Motohiro Re: [PATCH 01/12] vmscan: add shrink_slab tracepoints, Dave Chinner [PATCH 05/12] inode: convert inode_stat.nr_unused to per-cpu counters, Dave Chinner [PATCH 03/12] vmscan: reduce wind up shrinker->nr when shrinker can't do work, Dave Chinner Re: [PATCH 03/12] vmscan: reduce wind up shrinker->nr when shrinker can't do work, KOSAKI Motohiro Re: [PATCH 03/12] vmscan: reduce wind up shrinker->nr when shrinker can't do work, Dave Chinner

Previous by Date:	Re: long hangs when deleting large directories (3.0-rc3), Dave Chinner
Next by Date:	Re: long hangs when deleting large directories (3.0-rc3), Markus Trippelsdorf
Previous by Thread:	Re: [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong, Dave Chinner
Next by Thread:	[PATCH 06/12] inode: Make unused inode LRU per superblock, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]