Re: [PATCH 4/6] Ext4: fail if we try to use hole punch

To:	Josef Bacik <josef@xxxxxxxxxx>
Subject:	Re: [PATCH 4/6] Ext4: fail if we try to use hole punch
From:	Avi Kivity <avi@xxxxxxxxxx>
Date:	Tue, 16 Nov 2010 14:25:35 +0200
Cc:	david@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, cmm@xxxxxxxxxx, cluster-devel@xxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx
In-reply-to:	<1289840723-3056-5-git-send-email-josef@xxxxxxxxxx>
References:	<1289840723-3056-1-git-send-email-josef@xxxxxxxxxx> <1289840723-3056-5-git-send-email-josef@xxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6

On 11/15/2010 07:05 PM, Josef Bacik wrote:

Ext4 doesn't have the ability to punch holes yet, so make sure we return
EOPNOTSUPP if we try to use hole punching through fallocate.  This support can
be added later.  Thanks,

Instead of teaching filesystems to fail if they don't support thecapability, why don't supporting filesystems say so, allowing the failcode to be in common code?


--
error compiling committee.c: too many arguments to function

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 1/6] fs: add hole punching to fallocate, (continued) Re: [PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik Re: [PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik Re: [PATCH 1/6] fs: add hole punching to fallocate, Andreas Dilger Re: [PATCH 1/6] fs: add hole punching to fallocate, Andreas Dilger Re: [PATCH 1/6] fs: add hole punching to fallocate, Josef Bacik [PATCH 3/6] Ocfs2: handle hole punching via fallocate properly, Josef Bacik Re: [PATCH 3/6] Ocfs2: handle hole punching via fallocate properly, Jan Kara Re: [PATCH 3/6] Ocfs2: handle hole punching via fallocate properly, Joel Becker [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Jan Kara Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Avi Kivity <= Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Avi Kivity Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Greg Freemyer Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Ted Ts'o Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Pádraig Brady Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik [PATCH 6/6] Gfs2: fail if we try to use hole punch, Josef Bacik [PATCH 5/6] Btrfs: fail if we try to use hole punch, Josef Bacik

Previous by Date:	Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Jan Kara
Next by Date:	Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik
Previous by Thread:	Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Jan Kara
Next by Thread:	Re: [PATCH 4/6] Ext4: fail if we try to use hole punch, Josef Bacik
Indexes:	[Date] [Thread] [Top] [All Lists]