| To: | xfs-oss <xfs@xxxxxxxxxxx> |
|---|---|
| Subject: | [PATCH V3] xfstests: use stat not lstat when examining devices |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Fri, 04 Jun 2010 13:00:02 -0500 |
| In-reply-to: | <4C0939B9.9000109@xxxxxxxxxxx> |
| References: | <4C091B4E.5030503@xxxxxxxxxxx> <4C0939B9.9000109@xxxxxxxxxxx> |
| User-agent: | Thunderbird 2.0.0.24 (Macintosh/20100228) |
If you try running xfstests on lvm volumes which are symlinks,
it'll fail to run several tests because our _require_scratch
framework ultimately uses lstat not stat, and does not think
the lvm device (which is usually a symlink to a dm-X device)
is a block device. Sigh.
Just calling stat(1) with -L to follow the link should
suffice.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
---
diff --git a/common.rc b/common.rc
index 6bf1e12..db18884 100644
--- a/common.rc
+++ b/common.rc
@@ -584,7 +584,7 @@ _is_block_dev()
exit 1
fi
- [ -b $1 ] && src/lstat64 $1 | $AWK_PROG '/Device type:/ { print $9 }'
+ [ -b $1 ] && stat -L $1 | $AWK_PROG '/Device type:/ { print $9 }'
}
# Do a command, log it to $seq.full, optionally test return status
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH V2] xfstests: use stat not lstat when examining devices, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH V3] xfstests: use stat not lstat when examining devices, Alex Elder |
| Previous by Thread: | [PATCH V2] xfstests: use stat not lstat when examining devices, Eric Sandeen |
| Next by Thread: | Re: [PATCH V3] xfstests: use stat not lstat when examining devices, Alex Elder |
| Indexes: | [Date] [Thread] [Top] [All Lists] |