| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: fsetxattr() fails on a writable descriptor? |
| From: | Pádraig Brady <P@xxxxxxxxxxxxxx> |
| Date: | Wed, 09 Sep 2009 22:23:39 +0100 |
| Cc: | xfs@xxxxxxxxxxx, CoreutilsBugs <bug-coreutils@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx |
| In-reply-to: | <20090908184049.GA22050@xxxxxxxxxxxxx> |
| References: | <1251987642.3855.36.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4AA1A3E6.2020606@xxxxxxxxxxxxxx> <87k50den1e.fsf@xxxxxxxxxxxx> <1252309787.3852.8.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4AA4C950.3080303@xxxxxxxxxxxxxx> <1252318482.3852.18.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4AA6402D.8040209@xxxxxxxxxxxxxx> <20090908184049.GA22050@xxxxxxxxxxxxx> |
| User-agent: | Thunderbird 2.0.0.6 (X11/20071008) |
Christoph Hellwig wrote: > On Tue, Sep 08, 2009 at 12:29:49PM +0100, P??draig Brady wrote: >> fsetxattr() is failing for me when the permissions are readonly >> but the descriptor is writable as demonstrated by the program below. >> I've tried this on ext3 and ext4 with libattr-2.4.43-3.fc11.i586 >> and linux-2.6.30.5-43.fc11.i586 > > That's not XFS specifci behaviour. For all xattr operations, fd-based > or not we always do the full permission checks, and have done so since > day one. Check the routined xattr_permission in fs/xattr.c of the > kernel tree. It seems a bit unusual, but I'm not sure changing it now > is a good idea - the xattr support has been around for a long time. Sorry if you get this twice. Resending using another server... Thanks for this info Christoph. http://lxr.linux.no/#linux+v2.6.30.5/fs/xattr.c The specific issue we have is that `cp --preserve=xattr` gets an error when copying xattrs from a read only file. Since this has been an xattr issue since the start, we'll have to work around it. We'll probably temporarily set u+w on the new file to apply xattrs. cheers, Pádraig. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: xfsprogs: remove unused scripts, Eric Sandeen |
|---|---|
| Next by Date: | Re: fsetxattr() fails on a writable descriptor?, Michael Monnerie |
| Previous by Thread: | Re: fsetxattr() fails on a writable descriptor?, Christoph Hellwig |
| Next by Thread: | Re: fsetxattr() fails on a writable descriptor?, Michael Monnerie |
| Indexes: | [Date] [Thread] [Top] [All Lists] |