| To: | Christoph Hellwig <hch@xxxxxx> |
|---|---|
| Subject: | Re: [PATCH] fix compiler warning in xfsidbg |
| From: | Timothy Shimmin <tes@xxxxxxx> |
| Date: | Fri, 15 Aug 2008 15:32:41 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20080814203017.GA18619@lst.de> |
| References: | <20080814203017.GA18619@lst.de> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Thunderbird 2.0.0.16 (Macintosh/20080707) |
Christoph Hellwig wrote:
> attr_list_context.count is a ssize_t adn thus we need to use %zd, not
> %ld to print it.
>
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>
> Index: linux-2.6-xfs/fs/xfs/xfsidbg.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/xfsidbg.c 2008-08-14 15:24:38.000000000
> -0300
> +++ linux-2.6-xfs/fs/xfs/xfsidbg.c 2008-08-14 15:27:20.000000000 -0300
> @@ -4171,7 +4171,7 @@ xfsidbg_xattrcontext(xfs_attr_list_conte
> context->cursor->hashval, context->cursor->blkno,
> context->cursor->offset, context->cursor->pad1,
> context->cursor->pad2, context->cursor->initted);
> - kdb_printf("alist 0x%p, bufsize 0x%x, count %ld, firstu 0x%x\n",
> + kdb_printf("alist 0x%p, bufsize 0x%x, count %zd, firstu 0x%x\n",
> context->alist, context->bufsize, context->count,
> context->firstu);
> }
>
Looks good.
I didn't know the z modifier existed until now!
--Tim
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [REVIEW] Prevent direct I/O from mapping extents beyond eof, Lachlan McIlroy |
|---|---|
| Next by Date: | TAKE 985710 - stop rejecting options in remount, Tim Shimmin |
| Previous by Thread: | [PATCH] fix compiler warning in xfsidbg, Christoph Hellwig |
| Next by Thread: | [PATCH] use proper mnt_want_write calls for handle ioctls, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |