xfs
[Top] [All Lists]

[PATCH] Don't release root inode until finished using it

To: xfs@xxxxxxxxxxx, xfs-dev <xfs-dev@xxxxxxx>
Subject: [PATCH] Don't release root inode until finished using it
From: Lachlan McIlroy <lachlan@xxxxxxx>
Date: Tue, 05 Aug 2008 16:33:24 +1000
Reply-to: lachlan@xxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.16 (X11/20080707)
During unmount we're releasing the last reference on the root inode
before we've finished using it so move it after the XFS_SEND_UNMOUNT
hook.

--- a/fs/xfs/linux-2.6/xfs_super.c      2008-08-05 13:12:39.000000000 +1000
+++ b/fs/xfs/linux-2.6/xfs_super.c      2008-08-04 14:34:56.000000000 +1000
@@ -1132,8 +1132,6 @@ xfs_fs_put_super(
        error = xfs_unmount_flush(mp, 0);
        WARN_ON(error);

-       IRELE(rip);
-
        /*
         * If we're forcing a shutdown, typically because of a media error,
         * we want to make sure we invalidate dirty pages that belong to
@@ -1149,6 +1147,8 @@ xfs_fs_put_super(
                                unmount_event_flags);
        }

+       IRELE(rip);
+
        xfs_unmountfs(mp);
        xfs_icsb_destroy_counters(mp);
        xfs_close_devices(mp);


<Prev in Thread] Current Thread [Next in Thread>