Re: [PATCH V2] Always reset btree cursor after an insert

[Lachlan McIlroy <lachlan@xxxxxxx>]

Dave Chinner wrote:
> On Fri, Jun 20, 2008 at 11:42:28AM +1000, Lachlan McIlroy wrote:
> > Christoph Hellwig wrote:
> > > On Thu, Jun 19, 2008 at 04:17:15PM +1000, Lachlan McIlroy wrote:
> > > > After a btree insert operation a cursor can be invalid due to block
> > > > splits and a maybe a new root block.  We reset the cursor in
> > > > xfs_bmbt_insert() in the cases where we think we need to but it
> > > > isn't enough as we still see assertions.  Just do what we do elsewhere
> > > > and reset the cursor unconditionally.  Version 2 adds
> > > > XFS_WANT_CORRUPTED_GOTO checks throughout xfs_bmap.c and removes the
> > > > fix to revalidate the original cursor in xfs_bmbt_insert().
> > > Can you commit the XFS_WANT_CORRUPTED_GOTO checks as a separate patch
> > > before the cursor reset?  ACK from me for those hunks.
> > Yeah, no problem, thanks.
>
> The rest of it looks ok as well, Lachlan.

Ta.