xfs
[Top] [All Lists]

Re: [PATCH 1/2] simplify xfs_vn_listxattr

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 1/2] simplify xfs_vn_listxattr
From: Timothy Shimmin <tes@xxxxxxx>
Date: Fri, 06 Jun 2008 14:41:12 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20080603114837.GB2703@lst.de>
References: <20080603114837.GB2703@lst.de>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.14 (Macintosh/20080421)
Christoph Hellwig wrote:

>  
>       /*
>        * Then add the two synthetic ACL attributes.
> @@ -265,7 +316,7 @@ xfs_vn_listxattr(struct dentry *dentry, 
>       if (xfs_acl_vhasacl_access(inode)) {
>               error = list_one_attr(POSIX_ACL_XATTR_ACCESS,
>                               strlen(POSIX_ACL_XATTR_ACCESS) + 1,
> -                             data, size, &result);
> +                             data, size, &context.count);
>               if (error)
>                       return error;
>       }
> @@ -273,10 +324,10 @@ xfs_vn_listxattr(struct dentry *dentry, 
>       if (xfs_acl_vhasacl_default(inode)) {
>               error = list_one_attr(POSIX_ACL_XATTR_DEFAULT,
>                               strlen(POSIX_ACL_XATTR_DEFAULT) + 1,
> -                             data, size, &result);
> +                             data, size, &context.count);
>               if (error)

Need to fix param type.

re:

static int
list_one_attr(const char *name, const size_t len, void *data,
                size_t size, ssize_t *result)

typedef struct xfs_attr_list_context {
        struct xfs_inode                *dp;            /* inode */
        struct attrlist_cursor_kern     *cursor;        /* position in list */
        char                            *alist;         /* output buffer */
        int                             seen_enough;    /* T/F: seen enough of 
list? */
        int                             count;          /* num used entries */

=> mismatch type on &context.count (int) and list_one_attr's result
param (ssize_t => long)

--Tim


<Prev in Thread] Current Thread [Next in Thread>