| To: | Chris Wedgwood <cw@xxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] fix dir2 shortform structures on ARM old ABI |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Thu, 05 Jun 2008 01:34:17 -0500 |
| Cc: | Timothy Shimmin <tes@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20080605054938.GA17690@puku.stupidest.org> |
| References: | <47DB4181.7040603@sandeen.net> <480E89B5.8070006@sandeen.net> <481B7FD1.3030107@sandeen.net> <20080505070847.GH155679365@sgi.com> <481FDCD1.2010905@sgi.com> <4820609C.9090306@sandeen.net> <48477BD6.2020909@sandeen.net> <20080605054938.GA17690@puku.stupidest.org> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Thunderbird 2.0.0.14 (Macintosh/20080421) |
Chris Wedgwood wrote: > On Thu, Jun 05, 2008 at 12:38:30AM -0500, Eric Sandeen wrote: > >> Guys, this is SIMPLE, SAFE, and it fixes a CORRUPTION BUG. > > [...] > >>>> As it only defines __arch_pack for __arm__, > > __arch_pack is a horrible name and not very intuitive, what's wrong > with __on_disk or something else? > > seriously, if you don't like the name or the style of the fix that's fine, we can fix that up, but I went to enough trouble to track down the issue and test the fix it seems worth actually... fixing it. If you want to __on_disk annotate everything and only pack it on arm OABI that might be less hacky. cw almost convinced me of this. I was just going for "least invasive" here. -Eric |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] fix dir2 shortform structures on ARM old ABI, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH] factor out inode has attrs check, Timothy Shimmin |
| Previous by Thread: | Re: [PATCH] fix dir2 shortform structures on ARM old ABI, Eric Sandeen |
| Next by Thread: | Re: [PATCH] fix dir2 shortform structures on ARM old ABI, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |