xfs
[Top] [All Lists]

Re: [PATCH] Fix non-debug build for random32() use

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [PATCH] Fix non-debug build for random32() use
From: Lachlan McIlroy <lachlan@xxxxxxx>
Date: Wed, 30 Apr 2008 17:13:29 +1000
Cc: xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20080430065754.GB108924158@sgi.com>
References: <20080430065754.GB108924158@sgi.com>
Reply-to: lachlan@xxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.12 (X11/20080213)
Looks good to me.

David Chinner wrote:
Include linux/random.h in all builds, not just debug.

Signed-off-by: Dave Chinner <dgc@xxxxxxx>
---
 fs/xfs/linux-2.6/xfs_linux.h |    1 +
 fs/xfs/support/debug.h       |    2 --
 2 files changed, 1 insertion(+), 2 deletions(-)

Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_linux.h
===================================================================
--- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_linux.h 2008-04-22 15:06:11.000000000 +1000
+++ 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_linux.h 2008-04-30 16:38:38.754688626 +1000
@@ -75,6 +75,7 @@
#include <linux/delay.h>
#include <linux/log2.h>
#include <linux/spinlock.h>
+#include <linux/random.h>
#include <asm/page.h>
#include <asm/div64.h>
Index: 2.6.x-xfs-new/fs/xfs/support/debug.h
===================================================================
--- 2.6.x-xfs-new.orig/fs/xfs/support/debug.h 2007-08-02 22:13:10.000000000 +1000
+++ 2.6.x-xfs-new/fs/xfs/support/debug.h 2008-04-30 16:38:43.518080606 +1000
@@ -49,8 +49,6 @@ extern void assfail(char *expr, char *f,
#else /* DEBUG */
-#include <linux/random.h>
-
#define ASSERT(expr) \
(unlikely(expr) ? (void)0 : assfail(#expr, __FILE__, __LINE__))




<Prev in Thread] Current Thread [Next in Thread>