xfs
[Top] [All Lists]

Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()

To: nscott@xxxxxxxxxx
Subject: Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()
From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Mon, 28 Apr 2008 12:32:05 +0200
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>, David Chinner <dgc@xxxxxxx>, xfs@xxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxxx>, Adrian Bunk <bunk@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1209341212.23166.122.camel@edge.scott.net.au>
References: <200804261651.02078.vda.linux__2040.04651536724$1209223026$gmane$org@googlemail.com> <87iqy4wfjq.fsf@basil.nowhere.org> <20080426200701.GA10883@infradead.org> <20080426202630.GG17905@one.firstfloor.org> <20080426202323.GA14245@infradead.org> <1209341212.23166.122.camel@edge.scott.net.au>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.12 (X11/20060911)
> Having to compile chunks of XFS code in both kernel and
> userspace is also wierd (relative to other drivers),

Perhaps it would be a good idea to mark the files where that is expected
to work clearly.

> and
> its a side-effect of needing to do that (all the code
> dealing with specifics of ondisk format is shared).

But does that really need "STATIC"? Seems doubtful to me.

-Andi


<Prev in Thread] Current Thread [Next in Thread>