xfs
[Top] [All Lists]

Re: [PATCH] xfsqa: call _notrun in common.dump if dump utils not found

To: Timothy Shimmin <tes@xxxxxxx>
Subject: Re: [PATCH] xfsqa: call _notrun in common.dump if dump utils not found
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 25 Mar 2008 07:54:22 -0500
Cc: Barry Naujok <bnaujok@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <47E8960D.1000801@sgi.com>
References: <47E5CFBA.7060405@sandeen.net> <47E8703C.30603@sgi.com> <op.t8jyw8i63jf8g2@pc-bnaujok.melbourne.sgi.com> <47E87D97.9050900@sandeen.net> <47E88676.7080006@sgi.com> <47E8960D.1000801@sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.12 (Macintosh/20080213)
Timothy Shimmin wrote:
> Timothy Shimmin wrote:
>  > Eric Sandeen wrote:
>  >> Barry Naujok wrote:
>  >>> On Tue, 25 Mar 2008 14:23:40 +1100, Timothy Shimmin <tes@xxxxxxx> wrote:
>  >>>
>  >>>> Thanks, Eric.
>  >>>>
>  >>>> On IRIX:
>  >>>>  > where xfsdump xfsrestore xfsinvutil
>  >>>> /sbin/xfsdump
>  >>>> /usr/sbin/xfsdump
>  >>>> /sbin/xfsrestore
>  >>>> /usr/sbin/xfsinvutil
>  >>>>  > ls -l /sbin/xfsdump
>  >>>> lrwxr-xr-x    ... /sbin/xfsdump -> ../usr/sbin/xfsdump*
>  >>>>
>  >>>> I'll add the IRIX xfsrestore path and wait for Russell or
>  >>>> whoever to complain about BSD :)
>  >>> common.config sets up environment variables for the various
>  >>> tools used and can handle these paths. It has them for the
>  >>> xfsprogs tools (XFS_REPAIR_PROG, XFS_DB_PROG, etc) but
>  >>> nothing for the xfsdump tools.
>  >>
>  >> yeah, that may be better...
>  >>
>  > Okay. Fair point.
>  > I'll change common.dump to use the XFSDUMP_PROG etc....
>  > and common.config to set the PROG vars.
>  >
>  > --Tim
>  >
>  >
> 
> Okay, something like below then.
> Note, I only test for failure in common.dump and I need
> to filter out the fullpaths for the commands now as
> they output their full path.
> Oh and I changed a bit for the DEBUGDUMP which can
> use binaries in xfstests for debugging.
> Ughhh.

well, I don't want to make this too much work... it's not critical.

-eric


<Prev in Thread] Current Thread [Next in Thread>