Re: [PATCH] fix dir2 shortform structures on ARM old ABI

[Timothy Shimmin <tes@xxxxxxx>]

Eric Sandeen wrote:
> Eric Sandeen wrote:
>
> > I've helpfully provided structure layouts for the structures you mention
> > in the attached files, for your diffing pleasure.  I think you'll find
> > that it's not exactly as you described.
>
> Ah hell the arm structs I attached were for oldabi.  It's what I get for
> saving this fun work for late at night ;)
>
> Attached are eabi structs; still only xfs_dir2_data_entry, xfs_dinode
> and xfs_log_item seem to be affected by end-of-struct padding, of the
> structures you mention.  And xfs_log_item isn't a disk structure...
>
> which brings me back to, what specific failures do you see as a result
> of end-of-struct padding on these structs?
Which reminds me when writing 122 that I noticed with xfs_dinode
but didn't think the end of struct padding would affect things -
remember chatting to Nathan at the time IIRC.
Actually, now that I think about it (Tim waking up a bit :-),
the xfs_dinode_t is of limited value, because a lot of those
union fields at the end aren't actually used directly and just
give an indication of what the layout is like.
We are in the variable literal area there.


--Tim