xfs
[Top] [All Lists]

Re: [RFC, patch 1/2] Allow up to 1GB logs in mkfs.xfs

To: markgw@xxxxxxx
Subject: Re: [RFC, patch 1/2] Allow up to 1GB logs in mkfs.xfs
From: Lachlan McIlroy <lachlan@xxxxxxx>
Date: Mon, 25 Feb 2008 12:31:19 +1100
Cc: David Chinner <dgc@xxxxxxx>, Niv Sardi <xaiki@xxxxxxxxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <47C21585.8030504@sgi.com>
References: <20080221230833.GG155407@sgi.com> <ncctzk11zhl.fsf@sgi.com> <20080222050301.GP155407@sgi.com> <47BE6122.5040007@sgi.com> <20080222065338.GQ155407@sgi.com> <47C21585.8030504@sgi.com>
Reply-to: lachlan@xxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.9 (X11/20071031)
Mark Goodwin wrote:

David Chinner wrote:
On Fri, Feb 22, 2008 at 04:44:02PM +1100, Lachlan McIlroy wrote:
David Chinner wrote:
On Fri, Feb 22, 2008 at 01:44:38PM +1100, Niv Sardi wrote:
David Chinner <dgc@xxxxxxx> writes:
Increase the maximum log size supported by mkfs.
....
Hence logs larger than 2^30 will not work without kernel
modifications.
Therefore this change is limited to increasing the
log size to what we can currently support in kernel space with
needing kernel modifications.

Does anyone know of any work in mainline to address this?

I'm glad you got time to get around this, I didn't include it in the
first batch as I was told it 'broke things'.
Right. There's all sorts of nasties lurking if we go over 1GB in
size, but AFAICT up to 1GB is OK. There's still lots of validation
needing to be done - that's why this is an "RFC" and not something
ready for checkin yet. That's where more eye's and testers are
handy...
Dave, have you run any tests to see if we get any speed-ups with
this change?

Not yet - I've been running it through QA with different log sizes first to see if there's anything obviously broken with the kernel w.r.t. larger log sizes (nothing wrong so far).

What sort of improvements are we expecting? Log bound benchmarks will tail-push later than they do now, wont they? Which particular benchmarks are you thinking of running?


Does a larger on-disk log mean we can have a lot more items in the AIL?


<Prev in Thread] Current Thread [Next in Thread>