xfs
[Top] [All Lists]

Re: [REVIEW] Add lazy-counter conversion to xfs_repair

To: Barry Naujok <bnaujok@xxxxxxx>
Subject: Re: [REVIEW] Add lazy-counter conversion to xfs_repair
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 22 Feb 2008 11:37:29 -0600
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
In-reply-to: <op.t6wyesz53jf8g2@pc-bnaujok.melbourne.sgi.com>
References: <op.t6wyesz53jf8g2@pc-bnaujok.melbourne.sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.9 (X11/20071115)
Barry Naujok wrote:
> In response to the thread "Differences in mkfs.xfs and xfs_info output.",  
> xfs_repair has been improved to allow version changes/conversion of  
> filesystems.
> 
> So, this patch introduces the first in an ongoing series of in-place  
> filesystem version changes with xfs_repair and the "-c" (convert) option.
> 
> To turn on/off the lazy-superblock feature, run the following xfs_repair  
> commmand on your filesystem:
> 
> # xfs_repair -c lazycount=[0|1] <device>

How about adding this to xfs_admin as well, since some flag changes are
already in there?

i.e. xfs_admin -<something... l and L are taken> could invoke xfs_repair
-c lazycount ...?

It just strikes me as a tad confusing that to change v2 logs or
unwritten extent support, you use xfs_admin, and to change lazy sb
counters, you must run repair...

(I understand that repair must be run post-change, but a common tool to
invoke all feature changes seems good to me)

-Eric


<Prev in Thread] Current Thread [Next in Thread>