| To: | Barry Naujok <bnaujok@xxxxxxx> |
|---|---|
| Subject: | Re: [REVIEW] Fix end of device zeroing with > 1K sector sizes |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Thu, 21 Feb 2008 22:13:34 -0600 |
| Cc: | "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx> |
| In-reply-to: | <op.t6wqj6zq3jf8g2@pc-bnaujok.melbourne.sgi.com> |
| References: | <op.t6wqj6zq3jf8g2@pc-bnaujok.melbourne.sgi.com> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Thunderbird 2.0.0.9 (Macintosh/20071031) |
Barry Naujok wrote: > It has been found that mkfs with big sector sizes and devices/partitions > that aren't aligned to the sector size can cause short writes when zeroing > the end of the device. As mkfs.xfs didn't complete, the filesystem is > unmountable. > > Eg: > > # mkfs.xfs -f -L fs_1 -s size=4096 -l size=64m,sunit=512 /dev/hdd1 > mkfs.xfs: error - wrote only 130048 of 131072 bytes > > > The attached patch rounds down the device size to either 1K or > the sector size, whichever is greater. Hopefully to a multiple thereof ;) Looks good to me... and strangely familiar! -Eric > Barry. > |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/1] Documentation: correct XFS defaults for ikeep/noikeep mount options, Christoph Hellwig |
|---|---|
| Next by Date: | TAKE 977545 - xfsaild causing too many wakeups, David Chinner |
| Previous by Thread: | [REVIEW] Fix end of device zeroing with > 1K sector sizes, Barry Naujok |
| Next by Thread: | Re: [PATCH] don't encode parent in nfs filehandles unless nessecary, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |