xfs
[Top] [All Lists]

Re: [GIT PULL] XFS update for 2.6.23 - revert a commit

To: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [GIT PULL] XFS update for 2.6.23 - revert a commit
From: Timothy Shimmin <tes@xxxxxxx>
Date: Tue, 02 Oct 2007 10:13:48 +1000
Cc: linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.LFD.0.999.0710010753500.3579@woody.linux-foundation.org>
References: <20071001072350.DF61C58C4C0A@chook.melbourne.sgi.com> <alpine.LFD.0.999.0710010753500.3579@woody.linux-foundation.org>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.6 (Macintosh/20070728)
Linus Torvalds wrote:

On Mon, 1 Oct 2007, Tim Shimmin wrote:
Lachlan's description:
    This fix is for a problem that has been in XFS since day one.
    [XFS] Avoid replaying inode buffer initialisation log items if on-disk 
version is newer.
        ...

Why wasn't this in the commit logs? Now it just says it was reverted, with no actual reasoning *why*. And it apparently wasn't so obvious that no such reasoning is needed.

Gah. I ended up amending the commit and updating it with the comment.

Linus

Yeah, sorry about that. It occurred to me later on. I initially converted the sgi-mod (undo mod) to a git commit and then discovered git-revert and thought, hey I'll use that instead but then forgot to add all the text into it. D'oh. Thanks for the fixup.

--Tim


<Prev in Thread] Current Thread [Next in Thread>