xfs
[Top] [All Lists]

Re: [PATCH 5/4] simplify xfs_create/mknod/symlink prototype

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 5/4] simplify xfs_create/mknod/symlink prototype
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 14 Sep 2007 22:27:17 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20070914220520.GA19567@lst.de>
References: <20070914163041.GG7110@lst.de> <46EAD364.7060305@sandeen.net> <46EAD432.1030704@sandeen.net> <20070914220520.GA19567@lst.de>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.6 (Macintosh/20070728)
Christoph Hellwig wrote:
> On Fri, Sep 14, 2007 at 01:34:26PM -0500, Eric Sandeen wrote:
>>> -xfs_symlink [xfs]: 240
>>> +xfs_symlink [xfs]: 256
>> Although, that one is a little unfortunate ;)
> 
> and rather odd.  16 bytes more stack for passing in a 32bit scalar
> instead of a 32/64bit pointer, huh?  Then again we could just kill
> that parameter because symlinks always get the same mode..

it's a short on x86...  *shrug* I dunno, ask Jakub ;-)

-Eric


<Prev in Thread] Current Thread [Next in Thread>