xfs
[Top] [All Lists]

Re: [PATCH] clean up vnode^winode tracing

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [PATCH] clean up vnode^winode tracing
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 28 Aug 2007 15:26:48 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20070828200416.GG61154114@sgi.com>
References: <46D11F1B.5020409@sandeen.net> <20070828200416.GG61154114@sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 1.5.0.12 (X11/20070530)
David Chinner wrote:
> On Sun, Aug 26, 2007 at 01:35:07AM -0500, Eric Sandeen wrote:
>> Simplify vnode tracing calls by embedding function name & return addr
>> in the calling macro.
>>
>> Also do a lot of vnode->inode renaming for consistency, while
>> we're at it.
>>
>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
>>
>> Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_aops.c
>> ===================================================================
>> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_aops.c
>> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_aops.c
>> @@ -1525,8 +1525,7 @@ xfs_vm_bmap(
>>      struct inode            *inode = (struct inode *)mapping->host;
>>      struct xfs_inode        *ip = XFS_I(inode);
>>  
>> -    vn_trace_entry(XFS_I(inode), __FUNCTION__,
>> -                    (inst_t *)__return_address);
>> +    ip_trace_entry(XFS_I(inode));
> 
> s/ip_trace/xfs_itrace/
>

So xfs_itrace_entry, xfs_itrace_ref, xfs_itrace_exit etc is what you prefer?

-Eric


<Prev in Thread] Current Thread [Next in Thread>