xfs
[Top] [All Lists]

Re: [PATCH V2] remove unused BULKSTAT_FG_INLINE

To: xfs-oss <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH V2] remove unused BULKSTAT_FG_INLINE
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 15 Aug 2007 00:07:00 -0500
In-reply-to: <46C28571.2060206@sandeen.net>
References: <46C27EF8.2020004@sandeen.net> <46C28571.2060206@sandeen.net>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.6 (Macintosh/20070728)
Eric Sandeen wrote:
> Eric Sandeen wrote:
> 
>> I was looking at xfs_bulkstat with an eye towards stack reduction,
>> and came across this... doesn't help stack, but it doesn't appear
>> that the BULKSTAT_FG_INLINE bulkstat is ever used... 
>>
>> Is it there for a reason?  If not here's a patch.

Ah hell.  dmapi uses it in cvs... drat, foiled again.  (there's also
some stack savings to be had by removing the private_data bulkstat
field... but dmapi uses that too)

-Eric


<Prev in Thread] Current Thread [Next in Thread>